Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: generate a .env.local.php and use a SymfonyBootEnv adapter #27

Open
dogawaf opened this issue Sep 7, 2020 · 2 comments

Comments

@dogawaf
Copy link

dogawaf commented Sep 7, 2020

Hi Helmut

First of all, thx for sharing again awesome code with TYPO3 community. It is very valuable.

Using symfony framework (and symfon/flex), I see performance benefits on production system with the help of symfony:dump-env command.

Quoting the symfony doc:

In production, the .env files are also parsed and loaded on each request. So the easiest way to define env vars is by deploying a .env.local file to your production server(s) with your production values.

To improve performance, you can optionally run the dump-env command (available in Symfony Flex 1.2 or later):

Would it be possible that helhum/dotenv-connector also ships this functionality in order to make TYPO3+dotenv even faster?
The source code of the command in symfony/flex: https://github.com/symfony/flex/blob/master/src/Command/DumpEnvCommand.php

Cheers.

@helhum
Copy link
Owner

helhum commented Nov 21, 2020

That is implemented (optionally) in 3.x (and partly in 2.x)

@helhum helhum closed this as completed Nov 21, 2020
@helhum helhum reopened this Nov 21, 2020
@helhum
Copy link
Owner

helhum commented Nov 21, 2020

uhm sorry. remembered (and re-read) this ticket wrong. It is not implemented of course.
I have no immediate plans in creating this feature, especially because I don't have a need for it. So if someone wants to go ahead an create a PR, I'll happily review it. @dogawaf Want to give this one a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants