Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove team coloring #44

Open
jhamet93 opened this issue Nov 13, 2017 · 3 comments
Open

Remove team coloring #44

jhamet93 opened this issue Nov 13, 2017 · 3 comments

Comments

@jhamet93
Copy link
Contributor

This one is subjective but wanted to throw it out there:

Would you be open to removing the coloring of team names ? Can be super difficult to read in certain cases such as if the color chosen is yellow.

@homerchen19
Copy link
Owner

@jhamet93

Actually, some people told me coloring team name is the best feature for nba-go 😆
I understand it may be difficult to read when the background color is too bright and the font color is white. Thus, I have two suggestions. First, add another option to control coloring. Second, let font color be black if the background color is too bright.
Feel free to have more discussion about this!

@ChristianLapinig
Copy link
Contributor

I was thinking of having the team name either in it's secondary/primary color. For example, Warriors would be yellow background with blue text (or vice versa depending on the background that's already set), Magic would be blue background black font, etc.

@homerchen19
Copy link
Owner

@ChristianLapinig

That will be great! I think this could be solved by developing nba-color. Although it isn't good enough now, it could have more APIs like getFontColor(). Then, nba-go could use it just by calling API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants