Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the expected way to not require email to post? #96

Open
banagale opened this issue Jan 8, 2018 · 0 comments
Open

What is the expected way to not require email to post? #96

banagale opened this issue Jan 8, 2018 · 0 comments

Comments

@banagale
Copy link

banagale commented Jan 8, 2018

The default implementation of threadedcomments includes django_comments requirement of an email address be passed with the posted content from the comment form.

If I were extending django_comments with my own app, I'd create subclass CommentForm the way ThreadedCommentForm does, but include email = forms.EmailField(label=_("Email address"), required=False)

In fact, if I add this line to threadedcomments forms.py, I can submit without the email address. Realizing I don't want to modify this threadedcomments, what is the suggested way to get around this requirement?

For example, contrib-comments suggests creating a custom app. But since threadedcomments is already essentially this, is there a simpler way than creating yet another app next to comments and threaded comments to bypass this requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant