Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_resources is deprecated #98

Closed
nhairs opened this issue Dec 5, 2023 · 2 comments
Closed

pkg_resources is deprecated #98

nhairs opened this issue Dec 5, 2023 · 2 comments

Comments

@nhairs
Copy link

nhairs commented Dec 5, 2023

When running my own tests the following warning is thrown:
/code/.tox/py311/lib/python3.11/site-packages/imageio_ffmpeg/_utils.py:7: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

The fix appears to be to use importlib.resources

@almarklein
Copy link
Member

There's a nice migration guide here: https://importlib-resources.readthedocs.io/en/latest/migration.html

I recently made a similar change in another project (https://github.com/pygfx/wgpu-py/pull/421/files). I expect we can do something similar here.

There's no rush, since its only a warning (for now), but if someone is willing to contribute a PR that'd be great 😊

@almarklein
Copy link
Member

Fixed by #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants