Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra addons as npm dependencies #700

Open
henrikingo opened this issue Jul 29, 2018 · 1 comment
Open

extra addons as npm dependencies #700

henrikingo opened this issue Jul 29, 2018 · 1 comment

Comments

@henrikingo
Copy link
Member

The extras/ directory is simply empty in the npm package (via .npmignore). To provide an npm user the same seamless experience as is provided with git, it would be cool if the extras/ directory would be populated with symlinks to a node_modules path where those extra plugins are installed. This way the same path will work whether impress.js was installed via git or npm.

Note that since extra addons are optional, they should NOT be listed as dependencies in package.json. However, it seems to me they should be peerDepencies: https://docs.npmjs.com/files/package.json#peerdependencies

@janishutz
Copy link
Contributor

Yeah, I do agree, I'll look into this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants