Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

railpadding top and bottom not being set? #198

Closed
ddurose opened this issue Apr 9, 2013 · 4 comments
Closed

railpadding top and bottom not being set? #198

ddurose opened this issue Apr 9, 2013 · 4 comments
Labels

Comments

@ddurose
Copy link

ddurose commented Apr 9, 2013

It appears as though the top and bottom settings for railpadding are not being set in your plugin. I took a look in jquery.nicescroll.js and found line 716:

    var v,a,kp = ["left","right"];  //"top","bottom"

I decided to try and put the top and bottom in the array and it seems to work now.

@inuyaksa
Copy link
Owner

inuyaksa commented Apr 9, 2013

You found it!
I'd disabled because it need extensive test before release

@ddurose
Copy link
Author

ddurose commented Apr 9, 2013

Ok. Since it requires more testing, I won't make the modification myself. When you do release it, please indicate so in the release notes. Thanks!

@mediastuttgart
Copy link

definitely needs testing, since the height of the rail is currently not adjusted in regards to the padding values which needs to be subtracted. not that important, since it looks like there is a well done scrollbar plugin which is also maintained by the author, finally :)

@Anima-t3d
Copy link

I added padding and margin: #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants