Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: span tags of type int64 may lose precision #982

Open
SealinGp opened this issue Aug 22, 2022 · 1 comment
Open

[Bug]: span tags of type int64 may lose precision #982

SealinGp opened this issue Aug 22, 2022 · 1 comment
Labels

Comments

@SealinGp
Copy link

SealinGp commented Aug 22, 2022

Corresponding issue in the backend: jaegertracing/jaeger#3958

What happened?

i guess the package 'isomorphic-fetch' may loss of precision(int64) while proxy to load data from jaeger
jaeger-ui: v1.14.0
jaeger: v1.24.0

Steps to reproduce

  1. start jaeger
  2. change packages/jaeger-ui/src/api/jaeger.js:42 && start jaeger-ui
    image
    4.access /trace/4c5d7a066c367635704f06207dd56b45 page
    image
    image
    5.aceess api directly
    image

6.we can find out the value of "liveroom_sid" changed
780177723283783680 -> 780177723283783700

Expected behavior

jaeger : response int64 value "780177723283783680"
jaeger-ui: receive int64 value "780177723283783680" (but it shows "780177723283783700" )

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

v1.24.0

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@SealinGp SealinGp added the bug label Aug 22, 2022
@SealinGp
Copy link
Author

SealinGp commented Aug 22, 2022

sorry, my bad. this bug is because 780177723283783680 overflow js Number.MAX_VALUE to cause precision loss,and i change the code
image

will fix this, but it will copy bigint as string because of GoogleChromeLabs/jsbi#30
image

plz let me know it if there is better way to fix this situation

@SealinGp SealinGp mentioned this issue Aug 22, 2022
@yurishkuro yurishkuro changed the title [Bug]: /trace/traceID loss of precision [Bug]: span tags of type int64 may lose precision Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant