Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Dangerous use of tracer in plugin/storage/grpc/factory.go #5971

Open
yurishkuro opened this issue Sep 11, 2024 · 0 comments · May be fixed by #5979
Open

[jaeger-v2] Dangerous use of tracer in plugin/storage/grpc/factory.go #5971

yurishkuro opened this issue Sep 11, 2024 · 0 comments · May be fixed by #5979
Labels
area/otel area/storage bug help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

The factory is passed a tracer that it then passes to OTEL's ToClientConn() function, which automatically adds tracing instrumentation to gRPC connection. That means we may start generating new traces as we're trying to save spans to storage, thus causing an infinite loop of trace generation. The write path must always be devoid of tracing (or use very low sampling rate) to avoid this.

@yurishkuro yurishkuro added the help wanted Features that maintainers are willing to accept but do not have cycles to implement label Sep 11, 2024
ldlb9527 added a commit to ldlb9527/jaeger that referenced this issue Sep 12, 2024
ldlb9527 added a commit to ldlb9527/jaeger that referenced this issue Sep 12, 2024
ldlb9527 added a commit to ldlb9527/jaeger that referenced this issue Sep 12, 2024
ldlb9527 added a commit to ldlb9527/jaeger that referenced this issue Sep 18, 2024
ldlb9527 added a commit to ldlb9527/jaeger that referenced this issue Sep 18, 2024
ldlb9527 added a commit to ldlb9527/jaeger that referenced this issue Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel area/storage bug help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant