Help upgrading the linter #5974
Labels
enhancement
good first issue
Good for beginners
help wanted
Features that maintainers are willing to accept but do not have cycles to implement
Comments
yurishkuro
added
help wanted
|
@yurishkuro works fine in my machine. why it is asking for credentials ? git push origin dependabot/go_modules/internal/tools/github.com/golangci/golangci-lint-1.61.0 |
|
Create a new branch and push as a new PR. |
|
@yurishkuro before i was trying to push without creating fork :) . I don't know what i was thinking at that time. |
yurishkuro
pushed a commit
that referenced
this issue
Sep 13, 2024
## Which problem is this PR solving? fixes #5974 ## Description of the changes - fixing the problem created during upgrade of the linter ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Anish Bista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #5966 tries to upgrade the linter, but runs into many new lint issues that need to be fixed before upgrade can be merged. Most of them are about signed/unsigned conversions, which we generally force-ignore.
Success criteria:
gh pr checkout 5966andmake lintThe text was updated successfully, but these errors were encountered: