We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic: nil pointer dereference
The following code will cause a null pointer exception on the first iteration of the loop if span.TraceID has a zero value.
span.TraceID
https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/grpc/shared/grpc_client.go#L193-L209
var traces []*model.Trace var trace *model.Trace var traceID model.TraceID for received, err := stream.Recv(); !errors.Is(err, io.EOF); received, err = stream.Recv() { if err != nil { return nil, fmt.Errorf("stream error: %w", err) } for i, span := range received.Spans { if span.TraceID != traceID { trace = &model.Trace{} traceID = span.TraceID traces = append(traces, trace) } trace.Spans = append(trace.Spans, &received.Spans[i]) } }
The text was updated successfully, but these errors were encountered:
If this is an issue, I’m willing to create a PR to fix it.
Sorry, something went wrong.
No branches or pull requests
What happened?
The following code will cause a null pointer exception on the first iteration of the loop if
span.TraceID
has a zero value.Steps to reproduce
https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/grpc/shared/grpc_client.go#L193-L209
The text was updated successfully, but these errors were encountered: