Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor assembly (EE mode) tests. #1477

Open
starksm64 opened this issue Aug 21, 2024 · 1 comment
Open

Refactor assembly (EE mode) tests. #1477

starksm64 opened this issue Aug 21, 2024 · 1 comment

Comments

@starksm64
Copy link
Contributor

No description provided.

@brideck
Copy link
Contributor

brideck commented Sep 4, 2024

Whoever tackles this will probably want to refer to my changes here (https://github.com/jakartaee/platform-tck/tree/0f87c645faed4253a9eaf875cbf3467c614a8bcb) instead of just blindly converting the EE 10 version of these tests. (Alternatively, you can look at the PR where I updated them -- #1251)

These tests are intended to test the packaging of different versions of descriptors together in the same app, but there are a few problems with that:

  • As indicated by the package names (e.g. compat12_13), they were originally written to test things like J2EE 1.2 x J2EE 1.3, etc. which would obviously not be valid anymore for EE 11.
  • At some point, descriptors throughout the TCK were updated to the latest versions, which defeated the purpose of these particular tests and made all of the compat* packages functionally identical to each other.

To recapture the original intent, I nuked all of these packages and replaced them with a compat9_10. The EE spec states that an implementation only needs to support the current and previous versions of descriptors, so no additional testing is needed anymore. Obviously, for EE 11 that would want to instead be compat10_11. Better yet, the package should probably just be updated to compat, so it doesn't have to be renamed every major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to Assign
Development

No branches or pull requests

2 participants