Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: Jan supports new Model Folder and model.yaml architecture #3633

Open
dan-homebrew opened this issue Sep 11, 2024 · 0 comments
Open

epic: Jan supports new Model Folder and model.yaml architecture #3633

dan-homebrew opened this issue Sep 11, 2024 · 0 comments
Assignees
@louis-jan
Labels
category: model hub type: epic A major feature or initiative

Comments

@dan-homebrew
Copy link
Contributor

dan-homebrew commented Sep 11, 2024 •
edited
Loading

Goal

  • Sub-task of epic: Jan's path to cortex.cpp? #3690
  • Jan should support new Model folder and model.yaml architecture from cortex.cpp
  • Jan should be able to migrate up/down, and deal with migration errors
  • Migration safety should be assured via adequate tests on different OS and hardware

Key Questions

  • What is the strategy? Migration, or just handling old models as "legacy"? (and keeping nitro extension)
  • For migration:
    • Is this handled at cortex.cpp or at Jan?
    • Does cortex.cpp need to have a POST /migrations API?
  • For supporting legacy models:
    • Can Jan just have a legacy FS adapter to handle legacy model folder and model.json (how can it be detected?)
    • How do we cover this with sufficient test cases to make sure future intern does not blow it up?

Related
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-jan louis-jan

Labels
category: model hub type: epic A major feature or initiative
Projects
Jan & cortex.cpp
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nguyenhoangthuan99 @imtuyethan @dan-homebrew @louis-jan