Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hex VTK output #144

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Added Hex VTK output #144

merged 3 commits into from
Jun 16, 2023

Conversation

jmark
Copy link
Collaborator

@jmark jmark commented Jun 15, 2023

Title says it all. :)

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #144 (0d7fde4) into main (3cd7ce7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   97.71%   97.75%   +0.04%     
==========================================
  Files          25       25              
  Lines        3022     3078      +56     
==========================================
+ Hits         2953     3009      +56     
  Misses         69       69              
Impacted Files Coverage Δ
src/mesh/vtk_helper.jl 99.53% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I appreciate you adding this. Just have a few minor suggestions.

src/mesh/vtk_helper.jl Show resolved Hide resolved
src/mesh/vtk_helper.jl Outdated Show resolved Hide resolved
src/mesh/vtk_helper.jl Outdated Show resolved Hide resolved
src/mesh/vtk_helper.jl Outdated Show resolved Hide resolved
@jmark jmark assigned jlchan and unassigned jlchan and Davknapp Jun 16, 2023
Copy link
Owner

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlchan jlchan merged commit 7ea7874 into main Jun 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants