Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to deploy charm with storage parameter #1075

Open
dragomirp opened this issue Jul 19, 2024 · 1 comment · May be fixed by #1079
Open

Fail to deploy charm with storage parameter #1075

dragomirp opened this issue Jul 19, 2024 · 1 comment · May be fixed by #1079
Assignees
@addyess
Labels
area/application hint/3.x going on main branch in progress currently being worked on kind/bug indicates a bug in the project

Comments

@dragomirp
Copy link

Description

Trying to update libjuju from 3.5.0.0 to 3.5.2.0 breaks tests setting the storage parameter during deploy. Example CI run can be seen here. Deploying a locally build charm with:

        await ops_test.model.deploy(
            charm,
            application_name=FIRST_APPLICATION,
            num_units=3,
            series=CHARM_SERIES,
            storage={"pgdata": {"pool": "lxd-btrfs", "size": 2048}},
            config={"profile": "testing"},
        )

Will result in:

  File "/home/runner/work/postgresql-operator/postgresql-operator/tests/integration/ha_tests/test_restore_cluster.py", line 40, in test_build_and_deploy
    await ops_test.model.deploy(
  File "/home/runner/work/postgresql-operator/postgresql-operator/.tox/integration/lib/python3.10/site-packages/juju/model.py", line 1841, in deploy
    return await self._deploy(
  File "/home/runner/work/postgresql-operator/postgresql-operator/.tox/integration/lib/python3.10/site-packages/juju/model.py", line 2154, in _deploy
    storage=***k: parse_storage_constraint(v) for k, v in (storage or dict()).items()***,
  File "/home/runner/work/postgresql-operator/postgresql-operator/.tox/integration/lib/python3.10/site-packages/juju/model.py", line 2154, in <dictcomp>
    storage=***k: parse_storage_constraint(v) for k, v in (storage or dict()).items()***,
  File "/home/runner/work/postgresql-operator/postgresql-operator/.tox/integration/lib/python3.10/site-packages/juju/constraints.py", line 131, in parse_storage_constraint
    for m in STORAGE.finditer(constraint):
TypeError: expected string or bytes-like object

Trying to deploy something like:

await model.deploy("postgresql", storage={"pgdata": "lxd-btrfs,1,2G"}, config={"profile": "testing"})

Fails different validation:

TypeError: juju.client._definitions.Constraints() argument after ** must be a mapping, not str

I think the issue is caused by the additional validation added in model.py L2119

Urgency

Annoying bug in our test suite

Python-libjuju version

3.5.2.0

Juju version

3.4.4

Reproduce / Test

>>> import asyncio
>>> from juju.model import Model
>>> model = Model()
>>> await model.connect_current()
>>> await model.deploy("postgresql", storage={"pgdata": {"pool": "lxd-btrfs", "size": 2048}}, config={"profile": "testing"})
@dragomirp dragomirp mentioned this issue Jul 19, 2024
Merged
1 task
@addyess
Copy link
Contributor

addyess commented Jul 26, 2024 •
edited
Loading

@cderici -- i'm also affected by this

i tries switching to the new style of arguments:
using

storage = {
    "osd-devices": "8G,1",
    "osd-journals": "8G,1",
}

and that breaks when it tries parse these as client.Contraints in model.py

        if storage:
            storage = {
                k: client.Constraints(**v)
                for k, v in storage.items()
            }

@addyess addyess linked a pull request Jul 26, 2024 that will close this issue
Open
@hmlanigan hmlanigan added kind/bug indicates a bug in the project area/application in progress currently being worked on hint/3.x going on main branch labels Aug 1, 2024
@lucasgameiroborges lucasgameiroborges mentioned this issue Aug 2, 2024
Merged
1 task
@dragomirp dragomirp mentioned this issue Aug 8, 2024
Closed
@dragomirp dragomirp mentioned this issue Aug 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addyess addyess

Labels
area/application hint/3.x going on main branch in progress currently being worked on kind/bug indicates a bug in the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unify parse_storage_constraint or client.Constraints during deploy addyess/python-libjuju
3 participants
@dragomirp @addyess @hmlanigan