Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Dagger to KOIN #46

Open
jumaallan opened this issue Feb 4, 2021 · 8 comments · May be fixed by #61
Open

Migrate from Dagger to KOIN #46

jumaallan opened this issue Feb 4, 2021 · 8 comments · May be fixed by #61
Assignees
@wangerekaharun @jumaallan @andronicus-kim
Labels
enhancement New feature or request

Comments

@jumaallan
Copy link
Owner

Migrate the DI setup to KOIN, from Dagger
@jumaallan
Copy link
Owner Author

I think for the sample project, we should not use any DI. This will make the example easy to use by anyone who wants to learn how the library works

@jumaallan jumaallan added the enhancement New feature or request label Aug 19, 2021
@wangerekaharun
Copy link
Collaborator

I think for the sample project, we should not use any DI. This will make the example easy to use by anyone who wants to learn how the library works

with this in mind you should probably close this issue

@jumaallan
Copy link
Owner Author

This issue was meant to change the DI inside the library module itself, not the sample app

@wangerekaharun
Copy link
Collaborator

Seen the library module doesn't have any DI

@jumaallan
Copy link
Owner Author

Yeah, the re-write was going to use KOIN maybe, or we can just do away with the DI concept on the module

@jumaallan
Copy link
Owner Author

@andronicus-kim Feel free to contribute to this conversation

@andronicus-kim
Copy link
Collaborator

andronicus-kim commented Aug 20, 2021 •
edited
Loading

I think introducing DI on the module will make it a lot cleaner.

@jumaallan
Copy link
Owner Author

Great. Let's continue working from your current PR

@jumaallan jumaallan linked a pull request Aug 22, 2021 that will close this issue
Daraja DI using KOIN #61
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangerekaharun wangerekaharun

@jumaallan jumaallan

@andronicus-kim andronicus-kim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Daraja DI using KOIN andronicus-kim/android-mpesa-api
3 participants
@wangerekaharun @jumaallan @andronicus-kim