Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Fix helm common labels #32

Open
rouke-broersma opened this issue Jul 26, 2024 · 1 comment
Open

[all] Fix helm common labels #32

rouke-broersma opened this issue Jul 26, 2024 · 1 comment

Comments

@rouke-broersma
Copy link
Contributor

https://helm.sh/docs/chart_best_practices/labels/

Common labels are a bit inconsistent because I removed them from places where they were in the way (pod spec). We can probably re-add them everywhere and extend them with the other recommended labels, except in the pod spec. This probably would not trigger a pod rollout?

@rouke-broersma
Copy link
Contributor Author

Also set minimum kube version in Chart.yaml. Example: kubeVersion: ">=1.21.0-0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant