Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename engine.py to value.py #40

Open
PopovMP opened this issue May 24, 2023 · 0 comments
Open

Rename engine.py to value.py #40

PopovMP opened this issue May 24, 2023 · 0 comments

Comments

@PopovMP
Copy link

PopovMP commented May 24, 2023 •
edited
Loading

I suggest you rename engine.py to value.py.

Reasoning:

  • the engine name is misleading. The file doesn't contain some framework or domain logic.
  • the engine.py file contains a solo class named Value. The best name for it is value.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PopovMP