You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IIRC, that assertion added when working with ArtifactAndVersionFinder, but as workaround, we can change that line in ArtifactAndVersionFinder with:
final String pluginNameAsArtifactId = pluginKey + "-plugin";
And then, we can remove PluginNamingResolver.of(pluginKey) static factory. And start to re-condider getPluginVersion() implementation. After all, none of operation in PluginNamingResolver should throw an exception, since even if we cannot found any version, it will return 0.0.0.
The text was updated successfully, but these errors were encountered:
xsalefter
changed the title
kpm - not setting plugin version in possible
kpm - not setting plugin version should possible in PluginNamingResolver
Feb 8, 2024
If PluginNamingResolver created without specifying the
pluginVersion
, getPluginVersion() throw IllegalStateException. It is not correct, since we have a chances to analyzing version fromstringContainsVersion
.IIRC, that assertion added when working with ArtifactAndVersionFinder, but as workaround, we can change that line in
ArtifactAndVersionFinder
with:And then, we can remove
PluginNamingResolver.of(pluginKey)
static factory. And start to re-condidergetPluginVersion()
implementation. After all, none of operation inPluginNamingResolver
should throw an exception, since even if we cannot found any version, it will return0.0.0
.The text was updated successfully, but these errors were encountered: