Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A large number of imports slow down #59

Open
hubluesky opened this issue Apr 26, 2018 · 8 comments
Open

A large number of imports slow down #59

hubluesky opened this issue Apr 26, 2018 · 8 comments

Comments

@hubluesky
Copy link

When the number of rows in the excel table exceeds one thousand, the import will become very slow and slow.

@kimsama
Copy link
Owner

kimsama commented May 1, 2018

Hey, thank you for letting me know that.

I've tried a couple of hundred rows but never with thousands. (usually hundreds are no problem)

By the way, there seems to have no way to solve that issue because most of loading process is done within NPOI in case of loading excel file.

Any other ideas?

Cheers,

@hubluesky
Copy link
Author

I went to see the NPOI author's blog (http://blog.sina.com.cn/tonyqus), which has not been updated for many years, and GitHub (https://github.com/tonyqus/npoi) has not been updated for eleven months. But I saw two other Excel plugins, EPPlus and DocX on the author's blog. Maybe you can have a look.

@hubluesky
Copy link
Author

Let me see a comparison of NPOI and EPPlus (https://www.cnblogs.com/tanpeng/p/6155749.html), and EPPlus has a better advantage in quantity generation, and NPOI has a large amount of memory in addition to the problem of generating quantitative performance. (svn2github/npoi#13)

@kimsama
Copy link
Owner

kimsama commented May 3, 2018

Thanks for sharing the information. Never heard about EPPlus before. According to its note, it says it can load over 50000 rows within a few seconds. Sounds interesting.
I'll check it and make a branch for that if it is necessary.

Thanks.

Cheers,

ps. @hubluesky Are you developer of EPPlus project? (Just my curiosity though ;-)

@hubluesky
Copy link
Author

@kimsama No, I'm just a cleaner programmer.

@WeAthFoLD
Copy link

I personally found using Right Click->Reimport and rely on AssetPostProcessor to reimport excel file into asset data slow things down quite a bit, since unity has to process the file again.

I made a personal modification to the plugin, using a custom context menu action to do the importing (and thus avoiding asset reimporting), and the speed is so much faster. (Dropped from 1.0+s to nearly negligible). I believe this is a good direction to investigate.

@kimsama
Copy link
Owner

kimsama commented Jan 17, 2019

I personally found using Right Click->Reimport and rely on AssetPostProcessor to reimport excel file into asset data slow things down quite a bit, since unity has to process the file again.

I made a personal modification to the plugin, using a custom context menu action to do the importing (and thus avoiding asset reimporting), and the speed is so much faster. (Dropped from 1.0+s to nearly negligible). I believe this is a good direction to investigate.

Could you commit then push those changes for pull-request?

@WeAthFoLD
Copy link

Could you commit then push those changes for pull-request?

Gladly. I'll do it when I have time :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants