Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better name for Stack #1

Open
Wasabi375 opened this issue Apr 8, 2019 · 2 comments
Open

Better name for Stack #1

Wasabi375 opened this issue Apr 8, 2019 · 2 comments
Labels
question Further information is requested

Comments

@Wasabi375
Copy link
Contributor

I have renamed stak to Stack because I got annoyed by the wrong spelling. I also changed it to upper case to follow kotlin coding conventions.
The problem with this, as @elect86 pointed out, is that this might conflict with java.util.Stack which is a LIFO Vector implementation.

The question is, should we change the name of Stack again so that we no longer have an conflict? I'm personally not sure how often people use java.util.Stack anyways and then how often this would come in conflict with ours. This issue is to keep track of the problem

@Wasabi375 Wasabi375 added the question Further information is requested label Apr 8, 2019
@elect86
Copy link
Contributor

elect86 commented Apr 8, 2019

I happened to use java Stak only in imgui, but I do admit it's quite rare to see it

One alternative might be stacked

@elect86
Copy link
Contributor

elect86 commented Mar 6, 2020

also framed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants