Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

newConstructor doesn't honor argument order? #133

Open
redbaron opened this issue May 3, 2018 · 0 comments
Open

newConstructor doesn't honor argument order? #133

redbaron opened this issue May 3, 2018 · 0 comments

Comments

@redbaron
Copy link

redbaron commented May 3, 2018

both ContainerPort and ServicePort use newConstructor("newNamed", newParam("name"), ... )

but ContainerPort has argument names swapped, at least when generated from ksonnet with v1.8.0 apisepc:

containerPort:: {
    newNamed(containerPort="", name=""):: self.withContainerPort(containerPort).withName(name),

while order of args in ServicePort seems to be matching args to newConstructor:

servicePort:: {
...
    newNamed(name="", port="", targetPort=""):: self.withPort(port).withTargetPort(targetPort) + self.mixin.metadata.withName(name),
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant