Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test for k8s v1.22 --> v1.23 upgrade to use out of tree csi driver #2242

Closed
sonasingh46 opened this issue Apr 20, 2022 · 6 comments · Fixed by #2456
Closed

e2e test for k8s v1.22 --> v1.23 upgrade to use out of tree csi driver #2242

sonasingh46 opened this issue Apr 20, 2022 · 6 comments · Fixed by #2456
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@sonasingh46
Copy link
Contributor

sonasingh46 commented Apr 20, 2022

/kind bug

What steps did you take and what happened:
From Kubernetes v1.23 AzureDiskCSI driver is enabled by default.

An e2e test with following validations should be there:

  • Create a k8s cluster with v1.22.
  • Create a deployment/sts that uses PVC created via in-tree AzureDiskCSI driver.
  • Upgrade the k8s cluster to v1.23 and install out-of-tree AzureDiskCSI driver.
  • Validate that the existing pod using PVC created via in-tree provider keeps functioning.
  • Validate that a new pod using PVC created via the out-of-tree provider works.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 20, 2022
@sonasingh46
Copy link
Contributor Author

/assign sonasingh46

@sonasingh46
Copy link
Contributor Author

cc @CecileRobertMichon @shysank

@CecileRobertMichon
Copy link
Contributor

@sonasingh46 thanks for picking this up.

Can we leverage Helm to install AzureDisk and AzureFile on the cluster similar to what we did in #2209 to install external cloud provider?

https://github.com/kubernetes-sigs/azurefile-csi-driver/tree/master/charts#install-csi-driver-with-helm-3
https://github.com/kubernetes-sigs/azuredisk-csi-driver/tree/master/charts#install-csi-driver-with-helm-3

We should also add user-facing docs about installing CSI drivers post cluster create.

@sonasingh46
Copy link
Contributor Author

@CecileRobertMichon -- Yes. I am planning to use helm like we did for external cloud provider.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2022
@jackfrancis
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants