Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip hostname verification for external services #7121

Closed
jakubdyszkiewicz opened this issue Jun 26, 2023 · 0 comments · Fixed by #7633
Closed

Skip hostname verification for external services #7121

jakubdyszkiewicz opened this issue Jun 26, 2023 · 0 comments · Fixed by #7633
Labels
good first issue Good for newcomers kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jakubdyszkiewicz
Copy link
Contributor

Description

From kumahq/kuma-website#1370

It'd also be nice if you could disable hostname validation, but still verify the certificate against a caCert provided
@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature good first issue Good for newcomers triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jun 26, 2023
@jakubdyszkiewicz jakubdyszkiewicz mentioned this issue Jun 26, 2023
Open
@lahabana lahabana mentioned this issue Jun 12, 2023
Closed
alparslanavci added a commit to alparslanavci/kuma that referenced this issue Sep 4, 2023
@alparslanavci
feat(xds): add skip hostname verification for external services
224d397 
The external services were automatically doing verification for
hostnames on TLS certificates when TLS is enabled. This update
adds a flag to the external service definition to skip this
verification. By default, it is false.

Fix kumahq#7121

Signed-off-by: Alparslan Avci <[email protected]>
@alparslanavci alparslanavci mentioned this issue Sep 4, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ExternalService): add skip hostname verification for external services alparslanavci/kuma
1 participant
@jakubdyszkiewicz