Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Headers are being created as class attributes instead of instance attributes #361

Closed
erickvermot opened this issue May 4, 2017 · 2 comments
Closed

Headers are being created as class attributes instead of instance attributes #361

erickvermot opened this issue May 4, 2017 · 2 comments
Labels
discussion pri:important pri:normal
Milestone
2017.2

Comments

@erickvermot
Copy link
Contributor

erickvermot commented May 4, 2017 •
edited by diraol
Loading

Messages are being created with its header as a class attribute instead of a instance attribute. This makes all the instances have the same header, and consequently the same XID.
@beraldoleal beraldoleal added this to the 2017.1b3 milestone May 8, 2017
@diraol
Copy link
Contributor

diraol commented May 9, 2017

This may be fixed by the changes that need to be done to solve the issues: #157, #198 and #237
This is a behavior that we have already identified while proposing the solution for #157 and it is meant to be fixed by the refactor that solves this issue.

@beraldoleal beraldoleal modified the milestones: 2017.2b1, 2017.1b3 Jun 19, 2017
@erickvermot
Copy link
Contributor Author

erickvermot commented Jul 18, 2017 •
edited
Loading

master...erickvermot:new_generic_message
fixes this in a simple way.
This also fixes the XID problem still present (despite #224).

If the 'work_or_pass' logic is accepted (a4c1f05), MessageStruct class can become even simpler:
master...erickvermot:new_generic_message_work_or_pass

@erickvermot erickvermot mentioned this issue Jul 20, 2017
Open
@diraol diraol changed the title Headers are beeing created as class attributes instead of instance attributes Headers are being created as class attributes instead of instance attributes Aug 1, 2017
diraol added a commit to diraol/python-openflow that referenced this issue Nov 15, 2017
@diraol
Fixing repeated header XID between same class message instances
f151725 
Fix kytos#361
@diraol diraol closed this as completed in 1486700 Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion pri:important pri:normal
Projects
None yet
Milestone
2017.2
Development

No branches or pull requests
4 participants
@beraldoleal @cemsbr @diraol @erickvermot