Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The function polarSu3 uses sincos instead of sincospi #1436

Open
weinbe2 opened this issue Feb 1, 2024 · 0 comments
Open

The function polarSu3 uses sincos instead of sincospi #1436

weinbe2 opened this issue Feb 1, 2024 · 0 comments
Assignees
@maddyscientist
Labels
clean-up optimization

Comments

@weinbe2
Copy link
Contributor

weinbe2 commented Feb 1, 2024

As the title notes, the function polarSu3 in su3_project.cuh uses a quda::sincos call here: https://github.com/lattice/quda/blob/develop/include/su3_project.cuh#L106

This could be replaced with a sincospi, improving performance and reducing/eliminating the stack frame in some routines that utilize it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maddyscientist maddyscientist

Labels
clean-up optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maddyscientist @weinbe2