{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":529259159,"defaultBranch":"main","name":"ldk-node","ownerLogin":"lightningdevkit","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-08-26T13:00:53.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/60484029?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725445909.0","currentOid":""},"activityList":{"items":[{"before":"6d8382bca81f148f06e02d13e602ea9dcb6be4b6","after":"1a6a2ca1d0327bece964f92a31e67921f13ef316","ref":"refs/heads/main","pushedAt":"2024-09-13T07:14:00.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #357 from G8XSU/vss-client-upgrade\n\nVss-client upgrade to 0.3.x","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2511472847\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/357\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/357/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/357\">#357</a> from G8XSU/vss-client-upgrade"}},{"before":"648058e71141523658cfeb2eb370a305db47a256","after":"6d8382bca81f148f06e02d13e602ea9dcb6be4b6","ref":"refs/heads/main","pushedAt":"2024-09-05T15:11:25.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #355 from tnull/2024-09-add-copyright-headers\n\nAdd copyright notices where they were missing","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2507049360\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/355\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/355/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/355\">#355</a> from tnull/2024-09-add-copyright-headers"}},{"before":"bd42f5730fa336c040f77e26ef918dd150d81774","after":"648058e71141523658cfeb2eb370a305db47a256","ref":"refs/heads/main","pushedAt":"2024-09-05T13:41:44.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #356 from tnull/2024-09-pin-tokio-util","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2507085026\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/356\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/356/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/356\">#356</a> from tnull/2024-09-pin-tokio-util"}},{"before":"e805403b108aed31a0cafa4238ad32ade6d002b7","after":null,"ref":"refs/heads/dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7","pushedAt":"2024-09-04T10:31:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"4535c5fcff59b5816f0ef07ecce476c21f463dbc","after":"bd42f5730fa336c040f77e26ef918dd150d81774","ref":"refs/heads/main","pushedAt":"2024-09-04T10:31:42.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #353 from lightningdevkit/dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7\n\nBump actions/download-artifact from 3 to 4.1.7 in /.github/workflows","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2503921039\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/353\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/353/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/353\">#353</a> from lightningdevkit/dependabot/github_action…"}},{"before":null,"after":"e805403b108aed31a0cafa4238ad32ade6d002b7","ref":"refs/heads/dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7","pushedAt":"2024-09-03T22:30:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows\n\nBumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.\n- [Release notes](https://github.com/actions/download-artifact/releases)\n- [Commits](https://github.com/actions/download-artifact/compare/v3...v4.1.7)\n\n---\nupdated-dependencies:\n- dependency-name: actions/download-artifact\n  dependency-type: direct:production\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows"}},{"before":"ea448a1dda20bbe9a052bc7807c6b7e0ab78c360","after":"4535c5fcff59b5816f0ef07ecce476c21f463dbc","ref":"refs/heads/main","pushedAt":"2024-08-30T16:30:37.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #352 from tnull/2024-08-fee-estimator-refactor","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2494018004\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/352\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/352/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/352\">#352</a> from tnull/2024-08-fee-estimator-refactor"}},{"before":"ab7cc7066c45f512314db85a369bec53202e064b","after":"ea448a1dda20bbe9a052bc7807c6b7e0ab78c360","ref":"refs/heads/main","pushedAt":"2024-08-28T14:23:40.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #350 from tnull/2024-08-channel-config-refactor\n\nRefactor `ChannelConfig` / `MaxDustHTLCExposure`","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2485162683\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/350\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/350/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/350\">#350</a> from tnull/2024-08-channel-config-refactor"}},{"before":"398ece5f9e9645d46c6cd8ba7bb9b3b7de4d0f48","after":"ab7cc7066c45f512314db85a369bec53202e064b","ref":"refs/heads/main","pushedAt":"2024-08-28T14:19:06.000Z","pushType":"pr_merge","commitsCount":6,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #351 from tnull/2024-08-336-followup\n\n#336 followups","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2488877991\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/351\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/351/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/351\">#351</a> from tnull/2024-08-336-followup"}},{"before":"e233188f6ae532582b1e6646802e6d7fb3b480cb","after":"398ece5f9e9645d46c6cd8ba7bb9b3b7de4d0f48","ref":"refs/heads/main","pushedAt":"2024-08-27T08:08:51.000Z","pushType":"pr_merge","commitsCount":6,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #336 from slanesuke/2024-07-introduce-PaymentParameters\n\nAdd `SendingParameters` struct for customizable payments","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2443813769\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/336\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/336/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/336\">#336</a> from slanesuke/2024-07-introduce-PaymentParam…"}},{"before":"76fb23fec5ae2946d3a48f6ac36f8ae299be4b58","after":"e233188f6ae532582b1e6646802e6d7fb3b480cb","ref":"refs/heads/main","pushedAt":"2024-08-22T16:07:51.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #348 from tnull/2024-08-fix-bolt12-api","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2480067911\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/348\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/348/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/348\">#348</a> from tnull/2024-08-fix-bolt12-api"}},{"before":"3b645b3a863189a0fc620ed6d88e3d382a3b93b6","after":"76fb23fec5ae2946d3a48f6ac36f8ae299be4b58","ref":"refs/heads/main","pushedAt":"2024-08-19T15:26:14.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #327 from slanesuke/2024-07-expose-payer_note-in-PKbolt12\n\nExpose `payer_note` in `PaymentKind::Bolt12`","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2409729177\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/327\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/327/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/327\">#327</a> from slanesuke/2024-07-expose-payer_note-in-P…"}},{"before":"dffb790c6f7e209d9299d15771e6efd6b5cc4cf3","after":"3b645b3a863189a0fc620ed6d88e3d382a3b93b6","ref":"refs/heads/main","pushedAt":"2024-08-13T13:05:57.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #344 from tnull/2024-08-try-fix-caching-3\n\nFix caching third attempt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2463311326\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/344\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/344/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/344\">#344</a> from tnull/2024-08-try-fix-caching-3"}},{"before":"dcdbaf7707f622637b074f550458670bac6a2cd7","after":"dffb790c6f7e209d9299d15771e6efd6b5cc4cf3","ref":"refs/heads/main","pushedAt":"2024-08-13T08:35:38.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #343 from tnull/2024-08-try-fix-caching-2\n\nTry fixing caching once more","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2462642899\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/343\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/343/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/343\">#343</a> from tnull/2024-08-try-fix-caching-2"}},{"before":"2bbb76476a85c0bfa079398eab049ffc364acc4e","after":"dcdbaf7707f622637b074f550458670bac6a2cd7","ref":"refs/heads/main","pushedAt":"2024-08-12T14:54:14.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #342 from tnull/2024-08-try-fix-caching\n\nTry fix caching","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2460945864\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/342\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/342/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/342\">#342</a> from tnull/2024-08-try-fix-caching"}},{"before":"0d4ff375d60301b1ba3946e82dfe22557eec1784","after":"2bbb76476a85c0bfa079398eab049ffc364acc4e","ref":"refs/heads/main","pushedAt":"2024-08-12T11:23:30.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #341 from tnull/2024-08-make-cache-os-specific\n\nMake cache `key`s OS-specific","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2460729877\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/341\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/341/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/341\">#341</a> from tnull/2024-08-make-cache-os-specific"}},{"before":"952b889d82a03f5560f97f02100c37f207bae573","after":"0d4ff375d60301b1ba3946e82dfe22557eec1784","ref":"refs/heads/main","pushedAt":"2024-08-12T11:16:03.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #340 from tnull/2024-08-cache-downloads\n\nEnable caching for `bitcoind`/`electrs` in CI","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2460693237\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/340\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/340/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/340\">#340</a> from tnull/2024-08-cache-downloads"}},{"before":"d76509b92e4f8b0bd46a121608f4e9d6fbbcbe98","after":"952b889d82a03f5560f97f02100c37f207bae573","ref":"refs/heads/main","pushedAt":"2024-08-07T06:10:11.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #338 from tnull/2024-08-pin-tokio\n\nPin `tokio` to v1.38.1 to fix MSRV build","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2452547288\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/338\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/338/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/338\">#338</a> from tnull/2024-08-pin-tokio"}},{"before":"987f78c12ccd09e58343c76b2ed471804b84644f","after":"d76509b92e4f8b0bd46a121608f4e9d6fbbcbe98","ref":"refs/heads/main","pushedAt":"2024-08-02T21:45:11.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #337 from slanesuke/2024-08-fix-cln-test-cfg\n\nFix: added `cfg(cln_test)` to `Cargo.toml`","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2443845864\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/337\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/337/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/337\">#337</a> from slanesuke/2024-08-fix-cln-test-cfg"}},{"before":"8e5dbfe443a5a4a0452f59fd6adbe575236cb7ef","after":"987f78c12ccd09e58343c76b2ed471804b84644f","ref":"refs/heads/main","pushedAt":"2024-07-30T17:34:28.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #333 from tnull/2024-07-request-fees-once","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2437974733\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/333\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/333/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/333\">#333</a> from tnull/2024-07-request-fees-once"}},{"before":"5b9b60794d6201827f0c186bed6b2b0e180b1c31","after":"8e5dbfe443a5a4a0452f59fd6adbe575236cb7ef","ref":"refs/heads/main","pushedAt":"2024-07-30T17:34:08.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #334 from tnull/2024-07-fix-onchain-payment-variable-naming-bindings","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2437984812\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/334\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/334/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/334\">#334</a> from tnull/2024-07-fix-onchain-payment-variab…"}},{"before":"77a0bbede4f063ee50ca2aa36fb019e79d3f8707","after":"5b9b60794d6201827f0c186bed6b2b0e180b1c31","ref":"refs/heads/main","pushedAt":"2024-07-30T16:24:08.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #335 from tnull/2024-07-account-for-check-cfg\n\nAccount for `check-cfg`","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2438217377\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/335\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/335/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/335\">#335</a> from tnull/2024-07-account-for-check-cfg"}},{"before":"8dd379029d45287f25c412b2e1d7eb7ae197eba7","after":"77a0bbede4f063ee50ca2aa36fb019e79d3f8707","ref":"refs/heads/main","pushedAt":"2024-07-18T14:42:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Add BIP21 Unified QR Code Support (#302)\n\n* Add `UnifiedQrPayment` module for BIP21 URIs\r\n\r\nFirstly, I thought I staged and made commits for `unified_qr.rs`\r\nso sorry if this is out of order!\r\n\r\nBut in `unified_qr.rs` I\r\n  - I introduced the `UnifiedQrPayment` struct to handle creating\r\n    and paying BIP21 URIs\r\n  - `receive` generates a URI with an on-chain address and BOLT11\r\n     invoice and returns the URI as a string\r\n  - `send` will parse a given URI string and attempt to send the\r\n    BOLT12 offer, BOLT11 invoice, then if those fail the fallback\r\n    on-chain address will be paid to.\r\n  - Then I included tests for URI generation and URI parsing\r\n  - Also has logging and error handling for payment operations\r\n\r\n* Add `unified_qr_payment` payment handler to `Node`\r\n\r\n  - implement unified_qr_payment method to create the\r\n    Unified QR  payment handler\r\n  - Includes conditional UniFFI features and updates docs\r\n    with BIP21 and BOLT11 links\r\n\r\n* Add support for `unified_qr` in payment mod\r\n\r\n  - Included unified_qr in payment module\r\n  - Added `PaymentResult` and `UnifiedQrPayment`\r\n    from unified_qr for public use\r\n\r\n* Add bip21 crate to handle BIP21 URIs\r\n\r\n* Add `UnifiedQrPayment` and `PaymentResult` to `ldk_node.udl`\r\n\r\n  - Introduced `UnifiedQrPayment` method to `Node` interface\r\n  - Add `UnifiedQrPayment` interface with `receieve and\r\n    `send` methods\r\n  - Add `PaymentResult` interface (enum) with `Onchain`,\r\n    `Bolt11` and `Bolt12` fields\r\n\r\nThese changes add support for our UniFFI bindings and enable\r\nthe use of `unified_qr_payment` payment handler in Swift,\r\nand Kotlin.\r\n\r\n* Update `Error` enum with URI related errors\r\n\r\n  - Add `UriParameterFailed` and `InvalidUri` fields to\r\n    the `Error` enum\r\n  - Added related error  messages in the Display impl for\r\n    the new fields\r\n\r\n* Add `PaymentResult` import for UniFFI bindings\r\n\r\n  - Added `PaymentResult` so the .udl could access\r\n    the enum\r\n  - Added comment to explain the need to import any\r\n    re-exported items to enure they're accessible in\r\n    UniFFI. (becasue rustc says to add them in `lib.rs`\r\n\r\n* Add Unified QR `send`/`receive` integration tests\r\n\r\n  - Added `unified_qr_send_receive` test to verify the `UnifedQrPayment`\r\n    functionality\r\n  - Added logic to handle paying a `BOLT12` offer, `BOLT11` invoice,\r\n    and if those fail `On-chain` tx from a URI.\r\n  - Validated each payments successful event\r\n  - Ensured the off-chain and on-chain balacnes reflected the payment\r\n    attempts\r\n\r\n* Update PR with optimizations and nit fixups\r\n\r\nThe changes include:\r\n  - Fixed a handful of nits for better readability in\r\n    docs and simple grammar errors and made various name\r\n    changes that affected the committed files.\r\n  - Added a helper function in unified_qr.rs called\r\n    capitalize_qr_params to format the lightning param in\r\n    the receive method\r\n  - Removed the optional message in the receive method and\r\n    made it a required &str\r\n  - Adjusted UDL formatting to use tabs instead of spaces\r\n\r\nThese changes were made to improve code quality and\r\nmaintainability based on the review feedback\r\n\r\n* Refactor URI parsing and add Bolt12 offer in receive\r\n\r\nChanges include:\r\n  - Modified serialize_params to serialize both invoices and offers\r\n  - Refactored deserialize_temp by removing the code that was\r\n    parsing based on the lightning invoice/offer prefix. I instead\r\n    used for loop to iterate over each lightning parameter,\r\n    attempting to parse the string as an offer first, and then as an\r\n    invoice. May need to log an error if neither succeeds\r\n  - Added support for Bolt12 offers in the receive method\r\n  - Updated capitalize_params function to handle multiple lightning\r\n    parameters\r\n  - Added a generate_bip21_uri test to show what the uri looks\r\n    like in integration_tests_rust\r\n  - Adjusted integration tests. Still needs work\r\n\r\nStill trying to figure out a bug related to Bolt12 offers being\r\n\"paid\" when it should fall back to an on-chain tx\r\n\r\n* Update BOLT12 offer to use `lno` key\r\n\r\nIn this commit:\r\n  - In serialize_params, BOLT12 offers were changed\r\n    to be serialized with the `lno` key rather than\r\n    the `lightning` key\r\n  - During deserializing, I had to make the same update.\r\n    Used a match to check whether it was a `lightning`\r\n    or `lno` key and then parsed accordingly.\r\n  - Next, a small name change: capitalize_qr_params to\r\n    format_uri. Previously I changed the value after\r\n    \"&lightning\" to all caps, but the \"&lno=\" value\r\n    wasn't being changed. So, added a helper method inside\r\n    format_uri to capitalize the values given the key!\r\n  - Updated corresponding tests with `lno` update\r\n\r\nSmall nits:\r\n  - Updated QrPaymentResult with more thorough docs\r\n  - Added a parsing test with an offer\r\n\r\n* Refactor for clarity and improve error handling\r\n\r\nThis commit fixes a handful of minor comments/nits\r\nthat include:\r\n  - Updates to set the `bip21`  crates default-features to false,\r\n    to minimize dependencies.\r\n  - Enable the `std` feature since we use/benefit from it.\r\n\r\n  - In `receive` return `InvoiceCreationFailed` or `OfferCreationFailed`\r\n    when creating an invoice or offer. Rather than silently logging the\r\n    error.\r\n  - Also in `receive` we first check if an amount is specified, and if\r\n    not, return an error and abort.\r\n  - Pass in `Config` to `UnifiedQrPayment` struct to use the users config\r\n    network.\r\n  - In `send` instead of checking each network for the `NetworkChecked`\r\n    URI, we pass in the `Config::Network`.\r\n  - Simplifed param parsing in `deserialize_temp` by directly finding\r\n    the key and parsing the corresponding value.\r\n\r\n  - General documentation fixes.\r\n  - In parsing tests, moved longer invoice/offer strings into.\r\n    variables that start with expected_ for clarity.\r\n\r\n* Fix docs for clarity\r\n\r\nCleaned up the docs so they are easier to understand for the\r\nuser. Also changed the message param in receive to description.","shortMessageHtmlLink":"Add BIP21 Unified QR Code Support (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2324233477\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/302\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/302/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/302\">#302</a>)"}},{"before":"403c137c16914de5fe2cc1932b0ceaf523c1cadc","after":"8dd379029d45287f25c412b2e1d7eb7ae197eba7","ref":"refs/heads/main","pushedAt":"2024-07-15T08:03:27.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #326 from tnull/2024-07-unpin-cc\n\nRevert \"Pin `cc` to `1.0.105` for MSRV\"","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2408009970\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/326\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/326/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/326\">#326</a> from tnull/2024-07-unpin-cc"}},{"before":"8a4afb6e4e0366b05ede196d9859968afa385497","after":"403c137c16914de5fe2cc1932b0ceaf523c1cadc","ref":"refs/heads/main","pushedAt":"2024-07-12T11:25:19.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #324 from jbesraa/2024-07-10-fix-msrv\n\nFix `cc` msrv","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2400268421\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/324\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/324/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/324\">#324</a> from jbesraa/2024-07-10-fix-msrv"}},{"before":"13ec8df7b500b6950bc141c41a27baf85b0cc0a7","after":"8a4afb6e4e0366b05ede196d9859968afa385497","ref":"refs/heads/main","pushedAt":"2024-07-11T16:18:33.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #319 from lightningdevkit/2024-06-start-with-runtime\n\nAllow start from outer runtime","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2383188840\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/319\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/319/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/319\">#319</a> from lightningdevkit/2024-06-start-with-runtime"}},{"before":"ab059a8a9ba6c1e963c29e5c2359d9472160a92d","after":"13ec8df7b500b6950bc141c41a27baf85b0cc0a7","ref":"refs/heads/main","pushedAt":"2024-07-10T11:38:14.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #323 from jbesraa/2024-07-10-ignore-uniffi-target-folder\n\nIgnore all `target` folders including bindings","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2400144688\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/323\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/323/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/323\">#323</a> from jbesraa/2024-07-10-ignore-uniffi-target-…"}},{"before":"66fec694f2b1de81dcb3d40073698a03dfe25522","after":"ab059a8a9ba6c1e963c29e5c2359d9472160a92d","ref":"refs/heads/main","pushedAt":"2024-07-08T08:44:39.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #322 from tnull/2024-07-unpin-url","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2394947699\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/322\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/322/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/322\">#322</a> from tnull/2024-07-unpin-url"}},{"before":null,"after":"f2074f1dc8363ae04578b76e904cbbdbba6c18a7","ref":"refs/heads/2024-06-start-with-runtime","pushedAt":"2024-07-01T08:26:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Allow start from outer runtime\n\nWe add a `Node::start_with_runtime` method that allows to reuse a\npre-existing runtime, e.g., to avoid stacking runtime contexts when\nrunning in a tokio async environment.","shortMessageHtmlLink":"Allow start from outer runtime"}},{"before":"bd9bd683201c1597d8930ac4118fa950cedfd56c","after":"66fec694f2b1de81dcb3d40073698a03dfe25522","ref":"refs/heads/main","pushedAt":"2024-06-23T15:15:41.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"tnull","name":"Elias Rohrer","path":"/tnull","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/521467?s=80&v=4"},"commit":{"message":"Merge pull request #317 from elnosh/fix-inbound-comment\n\nFix inbound capacity comment","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2367182182\" data-permission-text=\"Title is private\" data-url=\"https://github.com/lightningdevkit/ldk-node/issues/317\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/lightningdevkit/ldk-node/pull/317/hovercard\" href=\"https://github.com/lightningdevkit/ldk-node/pull/317\">#317</a> from elnosh/fix-inbound-comment"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QwNzoxNDowMC4wMDAwMDBazwAAAAS1LqE4","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QwNzoxNDowMC4wMDAwMDBazwAAAAS1LqE4","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0yM1QxNToxNTo0MS4wMDAwMDBazwAAAARszhr4"}},"title":"Activity · lightningdevkit/ldk-node"}