Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Returned Value for User Cost Per Swap #688

Open
levmi opened this issue Jan 18, 2024 · 0 comments
Open

Simplify Returned Value for User Cost Per Swap #688

levmi opened this issue Jan 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request fees

Comments

@levmi
Copy link

levmi commented Jan 18, 2024

In building out flows on Terminal, we've noticed that it can be complicated and convoluted to grab the end cost to the user for Loop swaps (particularly on the Loop In side of things). We often have to calculate the end swap fee using CostServer, chain txes, and invoices. Through discussions internally, we've determined that it makes sense to fix this through a change on the client to just deliver a single value for the cost to the user and not require any calculations beyond that.

@levmi levmi added enhancement New feature or request fees labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fees
Projects
None yet
Development

No branches or pull requests

2 participants