Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination on ListSwaps #797

Open
rsafier opened this issue Jul 23, 2024 · 0 comments
Open

Pagination on ListSwaps #797

rsafier opened this issue Jul 23, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rsafier
Copy link

rsafier commented Jul 23, 2024

Is your feature request related to a problem? Please describe.

At some point will have a lot of swaps, and current filters do not allow one to filter by date range or limit output.

Describe the solution you'd like

Implement pagination pattern similar to ListPayments and other LND List gRPC calls. Also having a filter based on index like Payments in LND or datetime would be very helpful.

Describe alternatives you've considered

I will query all the history from Loop, then compare Ids with my audit tables, and update rows accordingly. Perfectly functional at current scale, will get nasty at some point.
Additional context

@hieblmi hieblmi added good first issue Good for newcomers enhancement New feature or request labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants