Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bluetooth battery #532

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat: add bluetooth battery #532

merged 1 commit into from
Jul 26, 2023

Conversation

kt286
Copy link
Contributor

@kt286 kt286 commented Jul 25, 2023

add bluetooth battery for DBus org.deepin.dde.bluetooth1.GetDevices

type DeviceInfo struct {
	Path        dbus.ObjectPath
	AdapterPath dbus.ObjectPath

	Alias            string
	Trusted          bool
	Paired           bool
	State            deviceState
	ServicesResolved bool
	ConnectState     bool

	UUIDs   []string
	Name    string
	Icon    string
	RSSI    int16
	Address string

	Battery byte    // added
}

@deepin-ci-robot
Copy link

Hi @kt286. Thanks for your PR.:smiley:

@BLumia BLumia requested a review from dengbo11 July 25, 2023 07:13
dengbo11
dengbo11 previously approved these changes Jul 25, 2023
View reviewed changes
@Decodetalkers
Copy link
Contributor

需要更新下go.mod

Decodetalkers
Decodetalkers requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Decodetalkers Decodetalkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.mod 更新下然后就可以合并了

@Decodetalkers
Copy link
Contributor

建议合成一个Commit吧，不过两个也可以，不过第二个Lint有点问题

@kt286
Copy link
Contributor Author

kt286 commented Jul 25, 2023

建议合成一个Commit吧，不过两个也可以，不过第二个Lint有点问题

我不太会合, 你那里 merge 的时候应该可以压缩成一个 commit

@Decodetalkers
Copy link
Contributor

好吧，两个也可以，不过我们这里没有自动合成一个Commit的Ci诶。。2333

@kt286
feat: add bluetooth battery
0d48080 
add bluetooth battery for DBus org.deepin.dde.bluetooth1.GetDevices
@kt286
Copy link
Contributor Author

kt286 commented Jul 25, 2023

好吧，两个也可以，不过我们这里没有自动合成一个Commit的Ci诶。。2333

合并成功了，哈哈哈

@Decodetalkers
Copy link
Contributor

/merge

@deepin-bot deepin-bot bot merged commit 17285e8 into linuxdeepin:master Jul 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Decodetalkers Decodetalkers Decodetalkers approved these changes

@dengbo11 dengbo11 dengbo11 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kt286 @deepin-ci-robot @Decodetalkers @dengbo11