Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window removes its own display animation #379

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

yixinshark
Copy link
Contributor

as title

Log: as title
Issue: linuxdeepin/developer-center#9728

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CompositeChanged方法中直接修改m_hasComposite的值可能影响依赖于该变量的其他代码部分。建议使用更优雅的逻辑来处理窗管窗口显示动画的屏蔽。
  • 注释“// 屏蔽应用自己的动画,默认使用窗管窗口显示动画”应该更详细地说明为什么需要这样做,以便其他开发者理解这一变更的上下文。

是否建议立即修改:

  • 是,建议立即修改以避免潜在的逻辑错误和提高代码的可读性。同时,应该提供充分的注释来解释为什么需要这样做。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xionglinlin, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 2e96449 into linuxdeepin:master Aug 22, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants