Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the hello dependency identifier && adjust thumbnail view image style #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Sep 24, 2024

1.Remove the hello dependency identifier
2.Adjust thumbnail view image style

Log: Remove the hello dependency identifier && adjust thumbnail view image style

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

…image style

  1.Remove the hello dependency identifier
  2.Adjust thumbnail view image style

Log: Remove the hello dependency identifier && adjust thumbnail view image style
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ThumbnailListDelegate.qml中,DropShadow组件的属性samples被设置为一个固定值,这可能会导致模糊效果不理想。建议根据需要调整这个属性。
  • HaveImportedView.qml中,onFilterTypeChanged事件的处理逻辑增加了对GStatus.loading的检查,这可能是为了确保在加载数据时不会更新筛选视图。然而,这种做法可能会导致在数据加载完成前筛选视图处于不稳定的状态。建议在数据加载完成后再触发更新。

是否建议立即修改:

@starhcq starhcq changed the title fix: Remove the hello dependency identifier fix: Remove the hello dependency identifier && adjust thumbnail view image style Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants