Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have a v0.2.2 release including the new _uncacheable function - so we can monkey patch for non-GET caching? #218

Open
willatlawford opened this issue Jun 23, 2023 · 4 comments

Comments

@willatlawford
Copy link

Good library, thank you - I have built some of this functionality by hand before but it's nice to see a good library instead.
Unfortunately, I can't make use of this library yet - as per several comments, I need to cache POST requests.*

As far as I can see from issues, allowing non-GET caching is planned**. It does at least look like the code has been refactored to allow monkey patching now*** but:

  • there isn't a versioned release containing this refactor yet - so I would have to install the dev branch from github directly to use it - which I don't love for my dependencies.
  • it would be even nicer if I could allow post caching directly by configuration.

Is there a plan to create a release soon? Is there a plan to allow non-GET via configuration?

Many thanks,
Will

* I have a machine learning use case where it is necessary to POST data, but the response for a given payload does not change.
** #75 : long2ice on Jan 21: "OK, just do it".
*** https://github.com/long2ice/fastapi-cache/blob/main/fastapi_cache/decorator.py#L82 Looks like you can override fastapi_cache.decorator._uncacheable

@willatlawford
Copy link
Author

willatlawford commented Jun 23, 2023

Just came across the v1.0.0 plan* which includes non-GET as configuration.
Perhaps we can have another sub v1 release prior to that so I can at least monkey patch _uncacheable?

* #145

@willatlawford willatlawford changed the title When will there be a release which doesn't block non-GET caching? Can we have a v0.2.2 release including the new _uncacheable function - so we can monkey patch for non-GET caching? Jun 23, 2023
@aausch
Copy link

aausch commented Aug 15, 2023

I'd appreciate seeing #273 in a sub 1.0.0 release too.

@aausch
Copy link

aausch commented Aug 24, 2023

Also #281

@mgguo
Copy link

mgguo commented May 22, 2024

+1, it would be really nice to have a minor release to have at least the _unreachable function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants