Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Reading a default duration of 0 from the config file will incorrectly display as 10 sec upon restarting #211

Open
snailfart opened this issue Sep 20, 2020 · 3 comments

Comments

@snailfart
Copy link

snailfart commented Sep 20, 2020

If the previous value is 0, selecting "Advanced Settings" in lxqt-config-notificationd always displays the predefined duration of 10 sec.
This issue is however only cosmetical; it doesn't reset the timeout I set previously until alter it manually.

lxqt-notificationd Version: 0.15.0

@zhrexl
Copy link
Contributor

zhrexl commented Sep 23, 2020

I agree that its not a good approach. I believe the idea was to prevent 0 sec. but in that case it should save the 10 sec. timeout.

The thing is, if you don't want to see notifications from a specific app you should blacklist it and if you don't want to show any notification then a notification-daemon should not be running but thats not a good option (some apps will not work if there isnt a notification-daemon running, i.e. electron apps) perhaps implementing a "silence mode" would be a good idea?

In that case the daemon would receive the notification but not show it, the same as setting timeout to 0.

@snailfart
Copy link
Author

I understand but this was not my intention at all, I wanted the notifications to never fade until I click them away, which worked very well, I can even set it to 0 through the GUI, it will just return to 10 sec after restarting the application.

@zhrexl
Copy link
Contributor

zhrexl commented Sep 25, 2020

Oh, I see. I misunderstood what you wanted to achieve.
I'll take a look to see what can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants