Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a XDG compatible autostart #4

Open
lytex opened this issue Mar 21, 2021 · 1 comment
Open

Make a XDG compatible autostart #4

lytex opened this issue Mar 21, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@lytex
Copy link
Owner

lytex commented Mar 21, 2021

Problem

Currently the script is copied to $XDG_CONFIG_HOME/autostart-scripts/git-sync.sh, which is not part of the XDG Standard. As far as I know, this is an undocumented feature existing only in KDE

Likewise, to prevent git-sync from starting twice if you logout and then login, an exit script is copied to $XDG_CONFIG_HOME/plasma-workspace/shutdown/exit-git-sync.sh, which is again nonstandard

Possible solutions

  • Create a user systemd service in $XDG_CONFIG_HOME/systemd/user. This would have the added benefit that we can delegate restarts with Restart=on-failure and possibly get rid of wrapper.sh (at least in a desktop environment, since I assume termux doesn't have those user systemd services), and exit-git-sync.sh which is defined in kde/install.sh I think this is the better option
  • Create a desktop entry in $XDG_CONFIG_HOME/autostart/git-sync.desktop. This would have to call git-sync.sh, but I'm not sure if there is an equivalent directory to store the desktop entries than will be run on logout, or if they are terminated on logout
  • If the restart is not managed by wrapper.sh, $NOTIF_START would have to be moved to git-sync.sh
@lytex lytex added the good first issue Good for newcomers label Mar 21, 2021
@lytex
Copy link
Owner Author

lytex commented Aug 15, 2022

This is solved by 7be84bf, will close it when is merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant