Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid component #48

Closed
rtivital opened this issue May 7, 2021 · 5 comments
Closed

Grid component #48

rtivital opened this issue May 7, 2021 · 5 comments
Assignees

Comments

@rtivital
Copy link
Member

rtivital commented May 7, 2021

@mantine/core should export Grid component with 12 columns flexbox grid

Exported components:

  • Grid – wrapper component
  • Col – column component, defines column width

Grid component props:

  • gutter (defaults to md) – defines horizontal and vertical spacing between columns – xs, sm, md, lg, xl – predefined in theme.spacing, number value to set spading in px.

Col component props:

  • spannumber – defines (span / 12)% of space which column will take
@rtivital rtivital self-assigned this May 7, 2021
@cstrat
Copy link
Contributor

cstrat commented May 11, 2021

This will be great!

Assuming this will provide a responsive underlay we can use for mobile/desktop UIs.

@rtivital
Copy link
Member Author

Assuming this will provide a responsive underlay we can use for mobile/desktop UIs.

That's a little bit tricky – currently I've done responsive support via useMediaQuery hook. It would be great to get some feedback before release. If you can assist that would be perfect.

To preview the feature:

@cstrat
Copy link
Contributor

cstrat commented May 11, 2021

I don't use SSR so for me useMediaQuery works fine.
From what I've read about responsiveness in the repo - you've had to sacrifice some capability to better support SSR, right?

@rtivital
Copy link
Member Author

It's more complicated – jss has full support for media queries with some bugs, (e.g., cssinjs/jss#1320), this is the only sacrifice which I hope will be resolved in future, so ssr does not restrict anything

@rtivital
Copy link
Member Author

Resolved in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants