Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for MatrixClient.initRustCrypto() to disable tracing #4177

Open
xiaoyue opened this issue Apr 26, 2024 · 0 comments
Open

Add option for MatrixClient.initRustCrypto() to disable tracing #4177

xiaoyue opened this issue Apr 26, 2024 · 0 comments
Labels
A-Developer-Experience A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Enhancement

Comments

@xiaoyue
Copy link

xiaoyue commented Apr 26, 2024

The tracing option is by default turned on in the initRustCrypto function (rust-crypto module). This results in excessive logging information with no control over the logging levels.

new RustSdkCryptoJs.Tracing(RustSdkCryptoJs.LoggerLevel.Debug).turnOn(); // Line 94 in src/rust-crypto/index.ts

When MatrixClient.initRustCrypto() calls it, it does not have options to disable tracing or adjust its logging level. In the Rust SDK, this tracing/logging level can be set with an environment variable. In matrix-js-sdk, however, it seems to be hard-coded.

Can we either use a similar environment variable, or have it as an optional parameter in the init function?

@MidhunSureshR MidhunSureshR added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants