Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomAvatarEventContent shouldn't reuse ImageInfo #4244

Closed
Johennes opened this issue Jun 14, 2024 · 0 comments · Fixed by #4245
Closed

RoomAvatarEventContent shouldn't reuse ImageInfo #4244

Johennes opened this issue Jun 14, 2024 · 0 comments · Fixed by #4245
Assignees
@t3chguy
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust

Comments

@Johennes
Copy link
Contributor

ImageInfo extends from FileInfo which includes bits for encrypted files. However, m.room.avatar is a state event. So encrypting it is pointless because room state itself is not encrypted.

See also matrix-org/matrix-spec#562 and ruma/ruma#397.
@dosubot dosubot bot added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Jun 14, 2024
@t3chguy t3chguy self-assigned this Jun 14, 2024
@t3chguy t3chguy mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Work around spec bug for m.room.avatar state event content type matrix-org/matrix-js-sdk
2 participants
@Johennes @t3chguy