Starred Messages View Screen #9182

yaya-usman · 2022-08-12T18:57:40Z

Task: vector-im/element-web#22453

Signed-off-by: Yaya Usman [email protected]

Here's what your changelog entry will look like:

✨ Features

Starred Messages View Screen (#9182). Contributed by @yaya-usman.

t3chguy · 2022-08-15T07:36:09Z

This needs a user-friendly title otherwise it won't make sense in the changelog

src/components/structures/RoomView.tsx

src/stores/RoomViewStore.tsx

src/components/views/rooms/RoomList.tsx

src/stores/RoomViewStore.tsx

src/components/views/rooms/RoomList.tsx

src/components/structures/FavouriteMessagesView.tsx

…ActionBar

…ew Header

into favMessage_Panel

SimonBrandner

I haven't had the time to look at most of the components yet but this is mostly looking good, just some smaller concerns

src/PosthogTrackers.ts

res/css/structures/_FavouriteMessagesView.pcss

src/components/structures/FavouriteMessagesView/ConfirmClearDialog.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessageTile.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessagesHeader.tsx

src/hooks/useFavouriteMessages.ts

SimonBrandner · 2022-08-24T07:11:27Z

src/hooks/useFavouriteMessages.ts

+    return {
+        isFavourite,
+        toggleFavourite,
+        getFavouriteMessagesIds,
+        reorderFavouriteMessages,
+        clearFavouriteMessages,
+        setSearchState,
+        isSearchClicked,
+
+    };


With all these things, it feels like these should be a store rather than a hook perhaps 🤔 When is the switch to account data going to happen?

Yeah, i figured out i needed a store instead of this, it's really a pain doing this with hooks only.

Regarding when is the switch to AccountData, i'll start working on it starting next month. For now i think we should stick to this.

res/css/structures/_FavouriteMessagesView.pcss

src/components/structures/FavouriteMessagesView/ConfirmClearDialog.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessageTile.tsx

into favMessage_Panel

src/components/views/rooms/RoomList.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessagesView.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessagesTilesList.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessagesPanel.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessagesHeader.tsx

src/components/structures/FavouriteMessagesView/FavouriteMessagesPanel.tsx

src/components/views/rooms/RoomList.tsx

…gesHeader.tsx Co-authored-by: Šimon Brandner <[email protected]>

Co-authored-by: Šimon Brandner <[email protected]>

andybalaam · 2022-12-07T12:14:46Z

I've done a rebase and addressed most of the comments, and created a new PR here: #9719

yaya-usman added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 12, 2022

yaya-usman requested review from andybalaam and SimonBrandner August 12, 2022 18:57

yaya-usman requested a review from a team as a code owner August 12, 2022 18:57

yaya-usman requested a review from germain-gg August 12, 2022 18:57

github-actions bot deployed to Netlify August 12, 2022 19:01 View deployment

yaya-usman removed the request for review from germain-gg August 12, 2022 19:01

yaya-usman marked this pull request as draft August 15, 2022 07:58

github-actions bot deployed to Netlify August 16, 2022 09:33 View deployment

SimonBrandner reviewed Aug 16, 2022

View reviewed changes

src/components/structures/RoomView.tsx Outdated Show resolved Hide resolved

src/stores/RoomViewStore.tsx Outdated Show resolved Hide resolved

src/components/views/rooms/RoomList.tsx Outdated Show resolved Hide resolved

yaya-usman force-pushed the favMessage_Panel branch from 4f3ff63 to ecd568b Compare August 16, 2022 10:09

github-actions bot deployed to Netlify August 16, 2022 10:13 View deployment

yaya-usman force-pushed the favMessage_Panel branch from ecd568b to 0e5545e Compare August 16, 2022 10:19

removed dead code related favorite messages panel

57a6de5

yaya-usman force-pushed the favMessage_Panel branch from 0e5545e to 57a6de5 Compare August 16, 2022 10:46

github-actions bot deployed to Netlify August 16, 2022 10:50 View deployment

SimonBrandner reviewed Aug 16, 2022

View reviewed changes

src/stores/RoomViewStore.tsx Outdated Show resolved Hide resolved

SimonBrandner reviewed Aug 16, 2022

View reviewed changes

src/stores/RoomViewStore.tsx Outdated Show resolved Hide resolved

SimonBrandner reviewed Aug 16, 2022

View reviewed changes

src/components/views/rooms/RoomList.tsx Outdated Show resolved Hide resolved

correct code nits

f92d917

SimonBrandner reviewed Aug 16, 2022

View reviewed changes

src/components/structures/FavouriteMessagesView.tsx Outdated Show resolved Hide resolved

SimonBrandner reviewed Aug 16, 2022

View reviewed changes

src/components/structures/FavouriteMessagesView.tsx Outdated Show resolved Hide resolved

github-actions bot deployed to Netlify August 16, 2022 11:34 View deployment

yaya-usman added 6 commits August 17, 2022 21:48

updated code: fetching of messages asynchronously

60e62a0

display sender details correctly and removed edit button from message…

d7f8a7e

…ActionBar

moved FavMessages related codes to one folder and added FavMessagesVi…

934d408

…ew Header

resolved conflict

914e58f

added the searchFilter, sort and clear all functionality

4b4bf4b

filter search terms and highlight

7d404b1

yaya-usman changed the title ~~Starred_Messages_Feature_Contd_III/Outreachy~~ Starred Message View Page Aug 21, 2022

yaya-usman changed the title ~~Starred Message View Page~~ Starred Messages View Page Aug 21, 2022

yaya-usman added 2 commits August 21, 2022 19:32

Merge branch 'develop' of https://github.com/yaya-usman/matrix-react-sdk

dc16558

into favMessage_Panel

typescript check error fix

5ffa8b3

github-actions bot deployed to Netlify August 21, 2022 16:57 View deployment

yaya-usman changed the title ~~Starred Messages View Page~~ Starred Messages View Screen Aug 21, 2022

Added clear all confirmation modal

9450fbf

yaya-usman requested a review from SimonBrandner August 22, 2022 11:16

github-actions bot deployed to Netlify August 22, 2022 11:20 View deployment

SimonBrandner reviewed Aug 24, 2022

View reviewed changes

yaya-usman added 4 commits August 24, 2022 15:37

written tests for Favourite Message View

bbca082

Merge branch 'develop' of https://github.com/yaya-usman/matrix-react-sdk

1874484

into favMessage_Panel

resolve code nits

7cc7a99

update favourite messages related test in MessageActionBar.tsx

97e39ed

github-actions bot deployed to Netlify August 24, 2022 13:56 View deployment

resolve typescript check problem

64b7c12

github-actions bot deployed to Netlify August 24, 2022 18:33 View deployment

yaya-usman marked this pull request as ready for review August 24, 2022 18:44

yaya-usman requested a review from SimonBrandner August 24, 2022 18:45

yaya-usman marked this pull request as draft August 24, 2022 18:49

SimonBrandner reviewed Aug 25, 2022

View reviewed changes

t3chguy reviewed Sep 2, 2022

View reviewed changes

src/components/views/rooms/RoomList.tsx Show resolved Hide resolved

yaya-usman and others added 2 commits September 6, 2022 23:02

Update src/components/structures/FavouriteMessagesView/FavouriteMessa…

7d04db3

…gesHeader.tsx Co-authored-by: Šimon Brandner <[email protected]>

Update src/hooks/useFavouriteMessages.ts

b6ba7b9

Co-authored-by: Šimon Brandner <[email protected]>

github-actions bot deployed to Netlify September 6, 2022 20:08 View deployment

andybalaam closed this Dec 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Starred Messages View Screen #9182

Starred Messages View Screen #9182

yaya-usman commented Aug 12, 2022 •

edited by github-actions bot

Loading

t3chguy commented Aug 15, 2022

SimonBrandner left a comment

SimonBrandner Aug 24, 2022

yaya-usman Aug 24, 2022

yaya-usman Aug 24, 2022

andybalaam commented Dec 7, 2022

Starred Messages View Screen #9182

Starred Messages View Screen #9182

Conversation

yaya-usman commented Aug 12, 2022 • edited by github-actions bot Loading

✨ Features

t3chguy commented Aug 15, 2022

SimonBrandner left a comment

Choose a reason for hiding this comment

SimonBrandner Aug 24, 2022

Choose a reason for hiding this comment

yaya-usman Aug 24, 2022

Choose a reason for hiding this comment

yaya-usman Aug 24, 2022

Choose a reason for hiding this comment

andybalaam commented Dec 7, 2022

yaya-usman commented Aug 12, 2022 •

edited by github-actions bot

Loading