Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up bad snapshots from existing databases. #256

Closed
DMRobertson opened this issue Aug 17, 2023 · 0 comments · Fixed by #267
Closed

Clean up bad snapshots from existing databases. #256

DMRobertson opened this issue Aug 17, 2023 · 0 comments · Fixed by #267

Comments

@DMRobertson
Copy link
Contributor

Followup to #255 and #211.

Kegan has some SQL prepared for this in a markdown document. We can use Till's migration machinery (#225, thanks Till) to run this script as a one-off.
@DMRobertson DMRobertson mentioned this issue Aug 22, 2023
Merged
DMRobertson pushed a commit that referenced this issue Aug 22, 2023
Migration to clean up bogus rooms
7a70d47 
These rooms have invalid state snapshots, leading to correctness
problems. The existence of such snapshots leaves us open to performance
problems due to gappy state updates.

We have prevented invalid state snapshots from being formed (#255, #266)
in the future. The remaining hole is to discard existing invalid
snapshots.

Closes #256.
@DMRobertson DMRobertson mentioned this issue Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migration to clean up bogus rooms matrix-org/sliding-sync
1 participant
@DMRobertson