Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC meson.build references absl_crc32c instead of absl_crc defined in wrap #1323

Open
haydenmc opened this issue Dec 6, 2023 · 1 comment

Comments

@haydenmc
Copy link
Contributor

haydenmc commented Dec 6, 2023

In grpc/meson.build@27, absl_crc32c is defined as a dependency:

absl_crc32c_dep = dependency('absl_crc32c')

However, if you include absl-cpp via Meson wrap, that dependency is defined as absl_crc:

absl_crc = absl_crc_dep

This results in the following error:

Executing subproject grpc

grpc| Project name: gRPC
grpc| Project version: 1.59.1
grpc| C compiler for the host machine: cc (gcc 13.2.0 "cc (Rev3, Built by MSYS2 project) 13.2.0")
grpc| C linker for the host machine: cc ld.bfd 2.41
grpc| C++ compiler for the host machine: c++ (gcc 13.1.0 "c++ (Rev7, Built by MSYS2 project) 13.1.0")
grpc| C++ linker for the host machine: c++ ld.bfd 2.40
grpc| Dependency absl_algorithm_container from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_any_invocable from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_base from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_bind_front from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_cleanup from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_cord from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_core_headers from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Run-time dependency absl_crc32c found: NO (tried pkgconfig)

subprojects\grpc-1.59.1\meson.build:27:18: ERROR: Dependency "absl_crc32c" not found, tried pkgconfig

Adjusting the dependency name in either location resolves this, but I imagine it's best to adjust the grpc meson.build file, which appears to be autogenerated by a script that is not yet committed to git.

Tagging @klokik for awareness as I see they've been working on grpc wrap support (huge thanks)!

@klokik
Copy link
Contributor

klokik commented Dec 10, 2023

Hey, that should be already fixed with this commit, which adds an alias for absl_crc32c to absl_crc 8e287c9

The thing is that packaged abseil does not provide a pkgconfig file for absl_crc which is more of a mesonbuild convenience thing, that nobody should be relying on. So for it to be universally compatible it should be crc32c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants