You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a annoymous AsyncTask object in au.com.wallaceit.reddinator.core.SubredditManager.loadDefaultSubredditsau methods. This object won't be cancelled. I think we should replace it with non-anonymous object and cancel it in the onDestroy() method.
public void loadDefaultSubreddits(){
try {
subreddits = new JSONObject(defaultSubreddits); // start with front page and all
} catch (JSONException e) {
e.printStackTrace();
}
new LoadDefaultSubredditsTask().execute();
}
Similarly, the finish() method in au.com.wallaceit.reddinator.activity can't guarantee loadPostTask will be cancelled.
The text was updated successfully, but these errors were encountered:
The reason that I am not cancelling them is because in most cases such as voting or commenting, even if the user exits the activity, it's still good to continue the operation in the background. However if you feel like there are some that should be cancelled then feel free to open a pull request.
There is a annoymous AsyncTask object in au.com.wallaceit.reddinator.core.SubredditManager.loadDefaultSubredditsau methods. This object won't be cancelled. I think we should replace it with non-anonymous object and cancel it in the onDestroy() method.
Similarly, the finish() method in au.com.wallaceit.reddinator.activity can't guarantee loadPostTask will be cancelled.
The text was updated successfully, but these errors were encountered: