-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility issues with rendering on iOS devices. #265
Comments
I can definitely change the version test to:
However the last existing
|
Yes, I agree with your point, haha. |
After testing, I've discovered that modifying the code to:
results in the following error when SharedMemory is disabled in desktop browsers:
|
Actually I think that block should be:
It seems like we should only use the non-shared option for web assembly modules when it's iOS < 16.4. I honestly don't know how the non-shared web assembly modules work at all because when I instantiate the web assembly module here: GaussianSplats3D/src/worker/SortWorker.js Line 155 in cc61292
I always specify shared memory. This is only shared between the web assembly module and the web worker; it's different that the shared memory between the web worker and the viewer. |
Just circling back to this one -- I've made some slight changes to the WASM module selection for iOS in the memory-optimizations branch. Would you be able to try that out to see if it works for you? |
Hello, after conducting my tests, there still seems to be an issue with iOS versions below 16.4. I think the following changes can be made to the code in the file /src/worker/SortWorker.js:
In the code, change the condition
if (iOSSemVer && iOSSemVer.major < 16) {
to
if (iOSSemVer && iOSSemVer.major <= 16 && iOSSemVer.minor < 4)
Moreover, according to the previous logic, the if inside the last else if should not be reachable.
Therefore, the modified code segment would be:
The text was updated successfully, but these errors were encountered: