Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to PMNDRS to replace their current Drei Splat wrapper with the mkkellogg dropinviewer #330

Open
newguy123-creator opened this issue Sep 12, 2024 · 1 comment

Comments

@newguy123-creator
Copy link

newguy123-creator commented Sep 12, 2024

Hi Mr Kellogg

PMNDRS has a bunch of cool helpers for React Three Fiber in their Drei library, among other things they have a Drei Splat, which currently is a wrapper for antimatter15's viewer, and it works great and very simple to set things up in R3F. The issue is antimatter15's viewer hasnt been updated in a very long time and your viewer seems to perform better in my testing, has more features, and works in VR.

Do you have any objections if I ask them to see if they are open to the idea of switching their wrapper from antimatter15 to yours instead?

@mkkellogg
Copy link
Owner

You're certainly welcome to ask them, but I think they will prefer to keep the current implementation for couple of reasons. The first is the simplicity of the implementation; mine is more complex and more difficult to debug or modify. The second reason is that they've had the chance over the past 9 months (or however long it has been since it was added) to do testing of their current implementation and if they switch now, it will undo all that testing.

Additionally, one of the core authors of Drei and R3F (drcmda) originally enlisted my help for authoring the Splat component, but for whatever reason he preferred the antimatter implementation over my approach: https://discourse.threejs.org/t/3d-gaussian-splatting-in-three-js/57858/15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants