Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment methods not respected when cancelled / failed and retry #378

Open
MelvinAchterhuis opened this issue Jul 18, 2022 · 1 comment
Open
Labels
Question / Issue Further information is requested

Comments

@MelvinAchterhuis
Copy link

MelvinAchterhuis commented Jul 18, 2022

Scenario:

Temporary disable a payment method in Shopware by deactivating it, or by removing it by Sales Channels -> Payment methods

Expected:

No new orders are placed with the disabled payment method

Result:

New orders are placed with the disabled payment method which is confusing, because we disabled it right?

Reproduce:

I could reproduce this issue with the following steps:

  • Disable the payment method and remove it from the sales channel (but keep it active in Mollie)
  • Place an order in test mode with "Cancelled" as feedback
  • You should be redirect to "frontend.mollie.payment.retry"
  • Now choose "Pay with a different payment method"
  • Now we can select all payment methods that are active in our Mollie account, which makes it possible to use the previous disabled payment method in Shopware

Not a big deal for me at the moment, because it makes kinda sense, but I think it should be communicated somewhere to prevent this from happening. It had me clueless for a few minutes.

However offering payment methods with rules, for example: customer groups, B2B / B2C , everything that has to do with the rule builder can bypassed by cancelling the payment and then pay through Mollie directly

@MelvinAchterhuis MelvinAchterhuis changed the title Payment methods not respected Payment methods not respected when cancelled / failed and retry Jul 18, 2022
@boxblinkracer
Copy link
Collaborator

Hi Melvin
thank you,
yes that is known.
this is indeed an older feature where we are aware of that edge case

i think it might be possible to provide a whitelist of payment methods for mollie,
but im not quite sure if it works in that spot.
so best thing is that we only provide the available sales channel methods when building the link.
so i'll check it out with a lower prio if that is ok :)

thanks for this

@boxblinkracer boxblinkracer added the Question / Issue Further information is requested label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question / Issue Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants