Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal close button pointer overridden by defaults #955

Open
janbrasna opened this issue Jul 18, 2024 · 1 comment · May be fixed by #956
Open

Modal close button pointer overridden by defaults #955

janbrasna opened this issue Jul 18, 2024 · 1 comment · May be fixed by #956
Labels
Bug 🪲 Something isn't working

Comments

@janbrasna
Copy link
Contributor

janbrasna commented Jul 18, 2024

Description

Even though .mzp-c-modal-close has cursor: pointer defined, the actual child button .mzp-c-modal-button-close itself is not setting it and since it's a ‹button› element it gets a good deal of browser styling defaults applied to it, overriding the pointer.

Steps to reproduce

See https://protocol.mozilla.org/components/detail/modal or visit e.g. https://www.mozilla.org/firefox/all/ where the ‹?› help popus are modal instances.

Expected result

The "X" close button should have pointer cursor to reconfirm it's an active element.

Actual result

The parent has it defined, but the actual button is brutally overridden by UA defaults for button element, i.e. effectively no pointer.

Environment

macOS Catalina
FXDE 129b5, Chromium 127r1313161

@janbrasna janbrasna added the Bug 🪲 Something isn't working label Jul 18, 2024
@janbrasna janbrasna linked a pull request Jul 18, 2024 that will close this issue
2 tasks
@janbrasna

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant