Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UAReferenceContext - causes circular references #558

Closed
2 tasks done
mpostol opened this issue Mar 19, 2021 · 0 comments · Fixed by #561
Closed
2 tasks done

UAReferenceContext - causes circular references #558

mpostol opened this issue Mar 19, 2021 · 0 comments · Fixed by #561
Assignees
@mpostol
Labels
Bug Bug in the code.
Milestone
SemanticData_6.X

Comments

@mpostol
Copy link
Owner

mpostol commented Mar 19, 2021 •
edited
Loading

Describe the bug

  • ParentNode and IsForward are redundant. The problem is for IsForward=false the browse path calculation is buggy.
  • Reference - there is no need to preserve original data

To Reproduce

Steps to reproduce the behavior:
The problem has been discovered in #510 - there are circular reference created

Expected behavior

IsForward must not be changed, Set SourceNode and TargetNode accordingly.

See also

There is extracted model SemanticData\Tests\USNodeSetValidationUnitTestProject\XMLModels\ProblemsToReport\HasOrderedComponent

HasOrderedComponentCircularReference
@mpostol mpostol added the Bug Bug in the code. label Mar 19, 2021
@mpostol mpostol self-assigned this Mar 19, 2021
@mpostol mpostol added this to the SemanticData_6.1.3 milestone Mar 19, 2021
mpostol added a commit that referenced this issue Mar 20, 2021
@mpostol
UAReferenceContext - causes circular references #558
db0dade 
- removed Reference property
- refactored UAReferenceContext
- Added UT
- UT +1:
mpostol added a commit that referenced this issue Mar 20, 2021
@mpostol
UAReferenceContext - causes circular references #558
5cf8c6b 
- Added UT
- UT +1:
mpostol added a commit that referenced this issue Mar 20, 2021
@mpostol
UAReferenceContext - causes circular references #558
a0219cc 
- Added UT
- UT +1:
mpostol added a commit that referenced this issue Mar 28, 2021
@mpostol
UAReferenceContext - causes circular references #558
55ff1c9 
- working on inheritance chain to replace the ReferenceKindEnum
- UT 👍
mpostol added a commit that referenced this issue Mar 31, 2021
@mpostol
UAReferenceContext - causes circular references #558
26cd699 
- fixed problem with GetBaseTypes methods.
- UT 👍
mpostol added a commit that referenced this issue Apr 2, 2021
@mpostol
UAReferenceContext - causes circular references #558
c3ab07a 
- removing ReferenceKind and replacing by IsSubtypeOf
- working copy
- UT :11:
mpostol added a commit that referenced this issue Apr 3, 2021
@mpostol
UAReferenceContext - causes circular references #558
29b295f 
-refactoring code
- fixed UT
- UT 👍
@mpostol mpostol mentioned this issue Apr 3, 2021
Merged
mpostol added a commit that referenced this issue Apr 4, 2021
@mpostol
UAReferenceContext - causes circular references #558
c6ec12c 
- removed IsSubtypeOf - it is not longer used.
- UT 👍
mpostol added a commit that referenced this issue Apr 4, 2021
@mpostol
Merge pull request #560 from mpostol/SemanticData-6.1.3
c8932c1 
UAReferenceContext - causes circular references #558
mpostol added a commit that referenced this issue Apr 4, 2021
@mpostol
UAReferenceContext - causes circular references #558
fcff314 
- removed IsSubtypeOf - it is not longer used.
- UT 👍
- fixes #558
@mpostol mpostol mentioned this issue Apr 4, 2021
Merged
mpostol added a commit that referenced this issue Apr 4, 2021
@mpostol
Merge pull request #561 from mpostol/SemanticData-6.1.3
5e51db6 
UAReferenceContext - causes circular references #558
mpostol added a commit that referenced this issue Apr 4, 2021
@mpostol
Import simple NodeSet2 file is incomplete #510
267fa13 
- after fixing the #558 generated the following mode. As prviously compiler cannot compile it because of the sequence of type declarations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpostol mpostol

Labels
Bug Bug in the code.
Projects
None yet
Milestone
SemanticData_6.X
Development

Successfully merging a pull request may close this issue.

UAReferenceContext - causes circular references #558 mpostol/OPC-UA-OOI
1 participant
@mpostol