Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #165

Open
marcinkunert opened this issue May 9, 2018 · 5 comments
Open

Add Docker support #165

marcinkunert opened this issue May 9, 2018 · 5 comments

Comments

@marcinkunert
Copy link

I would like to start the app as a Docker container. It would be nice if there was such possibility

@kazuki43zoo
Copy link
Member

Could you explain an your image about supporting Docker?

@marcinkunert
Copy link
Author

Sure. I'm now using this app as a base for teaching selenium tests on it. I have to have it running all the time on my server. To do this I have to download the git repository, build and run it. By default it uses port 8080 so I have to adjust it in pom.xml. If the server restarts (for some odd reason) I have to remember to start this app.

With a Docker container I could simply get an existing container with a prebuild app and run it by specifying which port I want to use. Docker would also handle the restart scenario.

@kazuki43zoo
Copy link
Member

Thanks for your explanation!
I will consider the Docker supporting when I have a time.
We welcome an your contributing at any time :D

@marcinkunert
Copy link
Author

Sure I could prepare the container build setup. The second step is to upload it to Docker Hub. It'a a free service as long as the container is publicly available. Are you willing to create a organization there and either add me as a team member or push the container by urself?

@QAInsights
Copy link

QAInsights commented Jul 9, 2022

@marcinkunert @kazuki43zoo I dockerized it and published it in the hub. Please check https://hub.docker.com/r/qainsights/jpetstore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants