New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't find unit tests for Ichimoku #87

Open

femtotrader opened this issue Dec 23, 2023 · 1 comment

Contributor

femtotrader commented Dec 23, 2023

Hi,

I think tests for Ichimoku are also missing.
What is your reference implementation for testing?

Kind regards

https://github.com/nardew/talipp/blob/master/talipp/indicators/Ichimoku.py
https://github.com/search?q=repo%3Anardew%2Ftalipp%20ichimoku&type=code

Owner

nardew commented Dec 23, 2023 •

edited

Loading

In general, all indicators are based on resources from school.stockcharts.com. For ichimoku cloud in particular I believe it is https://school.stockcharts.com/doku.php?id=technical_indicators:ichimoku_cloud. However, to be super honest, I think that leading lines are implemented a bit differently.

As far as tests are concerned, there are currently none. As far as I remember, I compared values manually with trading view (yeah, not ideal).

nardew mentioned this issue

Can't find unit tests for PivotsHL #85

Closed

femtotrader mentioned this issue

Can't find unit tests for McGinleyDynamic #88

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment