Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT-friendly documentation #611

Open
mtmk opened this issue Aug 23, 2024 · 4 comments
Open

AOT-friendly documentation #611

mtmk opened this issue Aug 23, 2024 · 4 comments
Milestone

Comments

@mtmk
Copy link
Collaborator

mtmk commented Aug 23, 2024

One thing I've been meaning to dive into is looking for gaps in documentation. PRs like this could include documentation that addresses cases such as folks wanting to remain AOT-friendly. Perhaps an article or some section in the docs.

Could also include documentation like you've mentioned about where the delineation is for projects that should be AOT-friendly. Either in CONTRIBUTING.md or the docs.

Originally posted by @rickdotnet in #607 (review)

@rickdotnet
Copy link
Collaborator

rickdotnet commented Aug 23, 2024

I thought there was already an issue about enhancing docs. I don't see it though, I started looking at the doc setup this morning. First time docfx'r.

Made it this far:

dotnet tool update -g docfx
git clone https://github.com/nats-io/nats.net.git
cd nats.net/docs
docfx docfx.json --serve

To expand on that comment, I think since AOT is a hot topic it should get a dedicated section that serves two purposes. One would be for users to have a quick understanding of which projects they might gravitate towards. But, also for developers to reference and understand the vision from the core team about how they should think about the project dependencies.

It's crucial that we avoid using non-AOT-friendly APIs, such as ad-hoc JSON serialization, in the core library.

@mtmk
Copy link
Collaborator Author

mtmk commented Aug 23, 2024

I thought there was already an issue about enhancing docs. I don't see it though

maybe this one #345

edit: btw I'm happy to merge this issue into #345 if you like

@rickdotnet
Copy link
Collaborator

rickdotnet commented Aug 23, 2024

Wth. My search must have been broken.

I think an AOT article is important to get out, so probably keep them separate. It's pretty buzzy and a frequent flyer in discussions. The other issue could maybe reflect the larger documentation review and collect known gaps. For example, serialization has been simplified. We could update the top of that article to give the happy path to new users, then provide more information for folks wanting to dive deeper.

@mtmk
Copy link
Collaborator Author

mtmk commented Aug 23, 2024

that makes sense. we can get an AOT page out first.

@mtmk mtmk added this to the 2.4.0 milestone Aug 24, 2024
@mtmk mtmk modified the milestones: 2.4.0, 2.5.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants