Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No verification of user scope requests #181

Open
bbockelm opened this issue May 6, 2024 · 3 comments
Open

No verification of user scope requests #181

bbockelm opened this issue May 6, 2024 · 3 comments

Comments

@bbockelm
Copy link
Contributor

bbockelm commented May 6, 2024

When I use the device code flow directly (no proxy to CILogon), after copy/pasting the generated URL from the terminal (e.g., https://localhost:8444/api/v1.0/issuer/device?user_code=8XF_A4D_65X), I get the following:

image

There was no option provided to the user to approve the requested scopes -- I could have asked for anything!

(Separately, it'd be useful to have a way to inject some CSS into the page -- or, alternately, consider a machine-readable response so I can intercept it at the proxy layer and create my own.)

@bbockelm bbockelm changed the title No verification of user activities No verification of user scope requests May 6, 2024
@jjg-123
Copy link
Contributor

jjg-123 commented May 6, 2024

Clarification needed: How are you authenticating? When you say no proxying through CILogon, are you assuming that Tomcat is handling the login? Normally scopes are displayed so I need to understand better how this is happening.

@bbockelm
Copy link
Contributor Author

bbockelm commented May 7, 2024

This is authenticating by HTTP header.

A quick perusal of the device code flow doesn't show any obvious way to hit a confirmation screen. Seems to go straight to the device-ok.jsp.

@jbasney
Copy link
Member

jbasney commented May 8, 2024

This is an issue in proxy mode also. See #107 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants